Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
==========================================
- Coverage 86.46% 86.39% -0.08%
==========================================
Files 49 49
Lines 19382 19382
==========================================
- Hits 16759 16745 -14
- Misses 2623 2637 +14
🚀 New features to boost your workflow:
|
fingolfin
force-pushed
the
mh-ai/matc6-long-orbit
branch
from
November 15, 2026 10:06
ad86424 to
246ece8
Compare
On the 27-dimensional projective node of MatC6.tst, 3^(1+6):Sp(6,3), the first C6 call returned TemporaryFailure in 3 of 100 seeds. Method selection then ran StabilizerChainProj on PG(26,25) before retrying C6: over 10^7 points in seed 6. There were two causes. RECOG.basis2 advanced k before unbinding a scalar gens[k], so the generator after each scalar was dropped unseen. With 13 scalars among 19 conjugates (seed 48) it found 2 of 3 hyperbolic pairs. C6 takes the conjugates of an element of the r-core R from TestAbelian as generators of R. The conjugators are the node's pseudo-random elements, which can be badly mixed: 6 of 8 generators lie in R, and in seeds 6 and 90, 27 and 32 of the first 40 random elements map to elements of order at most 2 in Sp(6,3). The conjugates then span a subspace of R/Z(R) that the group does not normalise, and some generator fails to rewrite. Now C6 adds a conjugate of a random subproduct under each failing generator and retries, up to 4 rounds per dimension of R/Z(R). The successful path is unchanged. With both fixes the first C6 call succeeds for seeds 1-100. Assisted-by: Generative AI
fingolfin
force-pushed
the
mh-ai/matc6-long-orbit
branch
from
November 15, 2026 16:09
246ece8 to
0c82d97
Compare
fingolfin
commented
Nov 15, 2026
| else | ||
| k:=k+1; | ||
| fi; | ||
| Unbind(gens[k]); |
Member
Author
There was a problem hiding this comment.
so here we advanced k before the unbind...
fingolfin
marked this pull request as ready for review
November 15, 2026 23:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the 27-dimensional projective node of
MatC6.tst,3^(1+6):Sp(6,3), the first C6 call returned TemporaryFailure in 3 of 100 seeds. Method selection then ranStabilizerChainProjonPG(26,25)before retrying C6: over 10^7 points in seed 6, taking 477 s in CI. There were two causes.First, there was a bug:
RECOG.basis2advanced k before unbinding a scalar gens[k], so the generator after each scalar was dropped unseen. With 13 scalars among 19 conjugates (seed 48) it found 2 of 3 hyperbolic pairs.Second problem: C6 takes the conjugates of an element of the r-core R from
TestAbelianas generators of R. The conjugators are the node's pseudo-random elements, which can be badly mixed: in our example, 6 of 8 generators lie in R, and in seeds 6 and 90, we find that 27 and 32 of the first 40 random elements map to elements of order at most 2 in Sp(6,3). The conjugates then span a subspace of R/Z(R) that the group does not normalise, and some generator fails to rewrite. Now C6 adds a conjugate of a random subproduct under each failing generator and retries, up to 4 rounds per dimension of R/Z(R). The successful path is unchanged.With both fixes the first C6 call succeeds for seeds 1-100.
Assisted-by: Generative AI
To review this, I recommend to turn on "Hide whitespace diffs"